Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/disk: don't error in absence of collected states #139079

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Jan 14, 2025

Previously, the absence of disk stats was considered an error by the disk monitor. In non-linux platforms, we don't have disk stats. This error was spamming the cockroach logs.

Epic: none
Release note: none

@jbowens jbowens requested a review from a team as a code owner January 14, 2025 22:16
@jbowens jbowens requested a review from aadityasondhi January 14, 2025 22:16
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previously, the absence of disk stats was considered an error by the disk
monitor. In non-linux platforms, we don't have disk stats. This error was
spamming the cockroach logs.

Epic: none
Release note: none
@jbowens jbowens added the backport-24.3.x Flags PRs that need to be backported to 24.3 label Jan 15, 2025
@jbowens
Copy link
Collaborator Author

jbowens commented Jan 15, 2025

TFTR!

bors r=RaduBerinde

@craig craig bot merged commit 5b7eddf into cockroachdb:master Jan 15, 2025
22 checks passed
@jbowens jbowens deleted the disk-silence branch January 15, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.3.x Flags PRs that need to be backported to 24.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants